Re: [net-next 05/15] i40e: add a comment on barrier and fix panic on reset

On Thu, 9 Jan 2014 18:42:00 +0400
Sergei Shtylyov [off-list ref] wrote:

Hello.

On 09-01-2014 16:52, Jeff Kirsher wrote:

quoted

From: Greg Rose <redacted>

quoted

The memory barrier used in maybe_stop_tx can use a comment.

quoted

Also add checks to VSI->rx_rings to ensure a kernel panic is not
induced.

    Don't see why this is made in one patch instead of two since the
two things look completely unrelated and even modifying different
files.

quoted

Change-ID: I48cc1bf1d6cf301818155b737edeef77c0d790c7
Change-ID: I1363a8445fbf521a26267849966296ed55f43ad8

    Why even 2 of them?

quoted

Signed-off-by: Greg Rose <redacted>
Signed-off-by: Mitch Williams <redacted>
Signed-off-by: Jesse Brandeburg <redacted>
Tested-by: Kavindya Deegala <redacted>
Signed-off-by: Jeff Kirsher <redacted>

WBR, Sergei

Yes, it's apparent that two different internal patches were compressed
together.  If its unacceptable to do this then I'll speak to Jeff about
splitting them.

- Greg