Re: [net-next 01/15] i40e: Expose AQ debugfs hooks
flat view
From: David Miller <davem@davemloft.net>
Date: 2014-01-07 20:35:00
From: Jeff Kirsher <redacted> Date: Tue, 7 Jan 2014 01:32:15 -0800
quoted hunk ↗ jump to hunk
@@ -1523,6 +1523,116 @@ static ssize_t i40e_dbg_command_write(struct file *filp, } else { dev_info(&pf->pdev->dev, "clear_stats vsi [seid] or clear_stats pf\n"); } + } else if (strncmp(cmd_buf, "send aq_cmd", 11) == 0) { + struct i40e_aq_desc *desc; + i40e_status ret; + desc = kzalloc(sizeof(struct i40e_aq_desc), GFP_KERNEL); + if (!desc) + goto command_write_done;
Please add an empty line between local variable declarations and code.
quoted hunk ↗ jump to hunk
+ } else if (strncmp(cmd_buf, "send indirect aq_cmd", 20) == 0) { + struct i40e_aq_desc *desc; + i40e_status ret; + u16 buffer_len; + u8 *buff; + desc = kzalloc(sizeof(struct i40e_aq_desc), GFP_KERNEL); + if (!desc) + goto command_write_done;
Likewise.