Thread (22 messages) 22 messages, 3 authors, 2014-01-05

Re: [net-next v5 04/17] i40e: Populate and check pci bus speed and width

flat view

From: David Miller <davem@davemloft.net>
Date: 2014-01-05 00:49:44

From: Bjorn Helgaas <bhelgaas@google.com>
Date: Sat, 4 Jan 2014 14:04:30 -0700
I don't see anything device-specific here.  This all looks to be
generic per the PCIe spec, without anything specific to the i40e.  In
fact, this new code looks almost identical to what Jacob added to
ixgbe with e027d1aec4bb, except that Jacob's code checks the whole
path up to the root, not just the single link leading to the device.

Since you're doing basically the same thing, it'd be nice if the code
looked basically the same.
Agreed.

I'm going to pull from Jeff's tree meanwhile and ask that this consolidation
happens as follow-up changes.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help