Re: [PATCH 5/5] bgmac: add support for Northstar SoC (BCM4707, BCM53018)

2014/1/3 Rafał Miłecki [off-list ref]:

2014/1/2 Hauke Mehrtens [off-list ref]:

quoted

On 01/02/2014 09:40 PM, Rafał Miłecki wrote:

quoted

 > +       if (ci->id == BCMA_CHIP_ID_BCM4707 ||

quoted

+           ci->id == BCMA_CHIP_ID_BCM53018) {

Please add a missing
if (bgmac->phyaddr != BGMAC_PHY_NOREGS)
return;
at the beginning of this 4707/53018 block

Why should I add that there?

This is what I can see in etcgmac.c version:
* $Id: etcgmac.c 414031 2013-07-23 10:54:51Z $

Hm, this is weird. I think this
* $Id: etcgmac.c 414031 2013-07-23 10:54:51Z $
is not any version, but just a timestamp of executing some cleaning-script.

Anyway, your reference code is 6.37.14.62:
https://github.com/RMerl/asuswrt-merlin/blob/master/release/src-rt-6.x.4708/include/epivers.h

And mine is 6.37.14.34 (GPL_RT_AC68U_30004374205.zip).

So it seems your is newer one...

OK, leave this code like it is, ignore that my comment for now.