Thread (26 messages) 26 messages, 6 authors, 2014-01-02

Re: [PATCH v4 0/2] sctp: Consolidate and ratelimit deprecation warnings

From: Ben Hutchings <hidden>
Date: 2013-12-23 22:55:23
Also in: linux-sctp, lkml

On Mon, 2013-12-23 at 08:29 -0500, Neil Horman wrote:
The SCTP protocol has several deprecation warnings in its setsockopt path that
can be triggered by unprivlidged users.  Since these are not ratelimited, we can
spam the logs quite easily here.  Since these are all deprecation warnings, and
that type of warning isn't uncommon in the rest of the kernel, lets make a
common pr_warn_deprecated macro to produce somewhat generalized ratelimited
deprecation warnings easily
[...]

No objection to these changes, but I think deprecation warnings should
log at least the command name and maybe also the pid of the caller.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help