[PATCH 1/4] net: phy: call put_device on device_register() failure
From: Levente Kurusa <hidden>
Date: 2013-12-13 19:23:00
Also in:
lkml
Subsystem:
ethernet phy library, networking drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2013-12-14 · Re: [PATCH 1/4] net: phy: call put_device on device_register() failure · Greg Kroah-Hartman <gregkh@linuxfoundation.org>
It is required to call put_device() if device_register() fails, so that we give up the last reference to the device. Calling put_device allows for mdiobus_release to be executed, kfreeing the bus. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Grant Likely <redacted> Signed-off-by: Levente Kurusa <redacted> --- drivers/net/phy/mdio_bus.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 5617876..b071af7 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c@@ -154,6 +154,7 @@ int mdiobus_register(struct mii_bus *bus) err = device_register(&bus->dev); if (err) { pr_err("mii_bus %s failed to register\n", bus->id); + put_device(&bus->dev); return -EINVAL; }
--
1.8.3.1