Re: [PATCH] ieee80211_i.h: Align struct ps_data.tim to unsigned long
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2013-12-19 08:19:17
Also in:
linux-wireless
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2013-12-19 08:19:17
Also in:
linux-wireless
On Wed, 2013-12-18 at 16:52 -0800, Joe Perches wrote:
Its address is used as an unsigned long *, so make sure that the tim u8 array is properly aligned. Signed-off-by: Joe Perches <joe@perches.com ---quoted
Care to send a proper patch? Otherwise I'll just re-do it and pick it up that way ...I had a passing thought about this when out today. It should really be set to __aligned(__alignof(unsigned long)) so here's a proper patch.
Hmm, yeah, I guess that's true, though sizeof() is probably >= on anything where Linux runs (and otherwise arrays get problematic anyway?) Anyway, I've dropped my patch in favour of yours. johannes