[patch 1/2] netiucv: improve state checking in conn_action_txdone

STALE4691d

From: <hidden>
Date: 2013-12-16 08:45:21
Also in: linux-s390

Revision v1 of 14 in this series.

Revisions (14)

2010-09-08 v1
2011-02-01 v1
2011-08-08 v1
2012-09-24 v1
2012-11-19 v1
2013-01-21 v1
2013-04-22 v1
2013-06-24 v1
2013-12-16 v1 current
2014-01-14 v1
2014-03-19 v1
2014-04-28 v1
2014-05-27 v1
2014-07-21 v1

From: Ursula Braun <redacted>

state checking in conn_action_txdone() is inconsistent.
This patch makes it consistent and issues a trace message
if an unexpected state is detected for the netiucv device.

Signed-off-by: Ursula Braun <redacted>
Signed-off-by: Frank Blaschka <redacted>
---
 drivers/s390/net/netiucv.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

--- a/drivers/s390/net/netiucv.c
+++ b/drivers/s390/net/netiucv.c

@@ -739,8 +739,12 @@ static void conn_action_txdone(fsm_insta
 
 	IUCV_DBF_TEXT(trace, 4, __func__);
 
-	if (conn && conn->netdev)
-		privptr = netdev_priv(conn->netdev);
+	if (!conn || !conn->netdev) {
+		IUCV_DBF_TEXT(data, 2,
+			      "Send confirmation for unlinked connection\n");
+		return;
+	}
+	privptr = netdev_priv(conn->netdev);
 	conn->prof.tx_pending--;
 	if (single_flag) {
 		if ((skb = skb_dequeue(&conn->commit_queue))) {

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help