Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set... | netdev

AF_ALG buggy with sendfile · Shawn Landden <hidden> · 2013-11-24
Re: AF_ALG buggy with sendfile · Shawn Landden <hidden> · 2013-11-24
Re: AF_ALG buggy with sendfile · Shawn Landden <hidden> · 2013-11-24
[PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Richard Weinberger <richard@nod.at> · 2013-11-24
Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Shawn Landden <hidden> · 2013-11-25
Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Eric Dumazet <hidden> · 2013-11-25
Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Shawn Landden <hidden> · 2013-11-25
[PATCH] Commit 35f9c09fe (tcp: tcp_sendpages() should call tcp_push() once) added an internal flag MSG_SENDPAGE_NOTLAST, similar to MSG_MORE. · Shawn Landden <hidden> · 2013-11-25
[PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Shawn Landden <hidden> · 2013-11-25
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Hannes Frederic Sowa <hidden> · 2013-11-25
[PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Shawn Landden <hidden> · 2013-11-25
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Richard Weinberger <hidden> · 2013-11-25
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Hannes Frederic Sowa <hidden> · 2013-11-29
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · Richard Weinberger <richard@nod.at> · 2013-11-29
Re: [PATCH] update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST · David Miller <davem@davemloft.net> · 2013-11-29
Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Richard Weinberger <richard@nod.at> · 2013-11-25
Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST · Eric Dumazet <hidden> · 2013-11-26

Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST

From: Eric Dumazet <hidden>
Date: 2013-11-26 00:02:00
Also in: linux-crypto, linux-fsdevel, lkml, stable

On Mon, 2013-11-25 at 08:42 +0100, Richard Weinberger wrote:

In the commit message of your patch you wrote "For all sendpage() providers, 
its a transparent change.". Why does AF_ALG need special handling?
If users have to care about MSG_SENDPAGE_NOTLAST it is no longer really an 
internal flag.

MSG_SENDPAGE_NOTLAST is an internal (kernel) flag.

Fact that I missed some MSG_MORE 'users' in the kernel was an oversight.

I am not saying your patch is not needed, I am only saying it reverts
a useful TCP optimization, and we can do better, dont we ?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help