Thread (18 messages) 18 messages, 5 authors, 2013-11-30

Re: net/usb/ax88179_178a driver broken in linux-3.12

From: Eric Dumazet <hidden>
Date: 2013-11-19 14:15:49
Also in: lkml, stable

Possibly related (same subject, not in this thread)

On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote:
On 13-11-19 05:04 AM, David Laight wrote:
quoted
quoted
From: Mark Lord
..
quoted
quoted
except the ax88179_178a driver still does not work in linux-3.12,
whereas it works fine in all earlier kernels.

That's a regression.
And a simple revert (earlier in this thread) fixes it.
So.. let's revert it for now, until a proper xhci compatible patch is produced.
...
quoted
There is a patch to xhci-ring.c that should fix the SG problem.
http://www.spinics.net/lists/linux-usb/msg97176.html

I think it should apply to the 3.12 sources.
I am running with that patch here now (thanks),
and it too appears to prevent the lockups.

But is this patch upstream already?
If yes, then it needs to get pushed out to -stable for 3.12 at least.

If not upstream, then the revert is probably safest for -stable,
rather than new code that has never been upstream before.
Both patches are attached to this email.
One or the other is required for the USB 3.0 network adapters to function in 3.12.
I do not see any error in commit f27070158d6754765f2
("ax88179_178a: avoid copy of tx tcp packets")

Quite the contrary in fact...

I suspect a TSO bug, and would rather disable TSO for this nic.

Have you tried to revert 3804fad45411b482
("USBNET: ax88179_178a: enable tso if usb host supports sg dma")
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help