Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

From
David Miller <davem@davemloft.net>
Date
2013-11-18 20:18:04
Also in
linux-wireless, lkml
Reply to
Govindarajulu Varadarajan, 2013-11-18
From: Govindarajulu Varadarajan <redacted>
Date: Tue, 19 Nov 2013 00:56:48 +0530 (IST)
Did you have a chance to look at this? Let me know how you want me to
fix this.
I said clearly that I don't want this change to be made, because in many
cases the "= NULL" assignment in the driver is desirable to elide when it
isn't necessary because the value is already NULL.  Therefore the NULL
check in dev_kfree_skb_irq() is basically coming for free.

Yes there are other cases, but it really doesn't matter enough to justify
your change.

Thanks.
Thread (19 messages) 19 messages, 4 authors, last reply 2013-11-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help