Thread (2 messages) flat view 2 messages, 2 authors, 2013-11-06

Re: [RESEND PATCH net-next] virtio-net: switch to use XPS to choose txq

From: David Miller <davem@davemloft.net>
Date: 2013-11-06 03:22:08
Also in: lkml, virtualization

From: Jason Wang <redacted>
Date: Tue,  5 Nov 2013 18:19:45 +0800
We used to use a percpu structure vq_index to record the cpu to queue
mapping, this is suboptimal since it duplicates the work of XPS and
loses all other XPS functionality such as allowing user to configure
their own transmission steering strategy.

So this patch switches to use XPS and suggest a default mapping when
the number of cpus is equal to the number of queues. With XPS support,
there's no need for keeping per-cpu vq_index and .ndo_select_queue(),
so they were removed also.

Cc: Rusty Russell <redacted>
Cc: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Rusty Russell <redacted>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <redacted>
---
Resend since the previous complie warning disappears after commit
3573540cafa4296dd60f8be02f2aecaa31047525
(netif_set_xps_queue: make cpu mask const).
Yep, looks great, applied.  Thanks Jason!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help