Thread (3 messages) 3 messages, 3 authors, 2013-11-29

Re: [PATCH v2 net] af_packet: block BH in prb_shutdown_retire_blk_timer()

From: David Miller <davem@davemloft.net>
Date: 2013-11-29 21:11:58

From: Daniel Borkmann <redacted>
Date: Fri, 29 Nov 2013 10:19:29 +0100
On 11/29/2013 09:53 AM, Veaceslav Falico wrote:
quoted
Currently we're using plain spin_lock() in
prb_shutdown_retire_blk_timer(),
however the timer might fire right in the middle and thus try to
re-aquire
the same spinlock, leaving us in a endless loop.

To fix that, use the spin_lock_bh() to block it.

CC: "David S. Miller" <davem@davemloft.net>
CC: Daniel Borkmann <redacted>
CC: Willem de Bruijn <willemb@google.com>
CC: Phil Sutter <phil@nwl.cc>
CC: Eric Dumazet <edumazet@google.com>
Reported-by: Jan Stancek <jstancek@redhat.com>
Tested-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Veaceslav Falico <redacted>
Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer
implementation.")
Acked-by: Daniel Borkmann <redacted>
Applied and queued up for -stable, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help