Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath
From: Thomas Graf <tgraf@suug.ch>
Date: 2013-11-27 22:35:14
From: Thomas Graf <tgraf@suug.ch>
Date: 2013-11-27 22:35:14
On 11/25/13 at 03:40pm, Jesse Gross wrote:
On Fri, Nov 22, 2013 at 8:56 AM, Thomas Graf [off-list ref] wrote:quoted
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h index 07ef2c3..a6863e2 100644 --- a/include/uapi/linux/openvswitch.h +++ b/include/uapi/linux/openvswitch.h@@ -40,7 +40,15 @@ struct ovs_header { #define OVS_DATAPATH_FAMILY "ovs_datapath" #define OVS_DATAPATH_MCGROUP "ovs_datapath" -#define OVS_DATAPATH_VERSION 0x1 + +/* V2: + * - API users are expected to provide OVS_DP_ATTR_USER_FEATURES + * with NLM_F_REPLACE when creating the datapath. + */ +#define OVS_DATAPATH_VERSION 2I'm not sure that I understand this comment - I guess it means that there's no legacy path when using NLM_F_REPLACE?
It means that if the V2 caller does not provide user features the existing user features are preserved upon NLM_F_REPLACE. V1 users can't be aware and the user features are always reset.