Re: [PATCH net] netem: fix loss generators
From: Hagen Paul Pfeifer <hidden>
Date: 2013-11-27 21:28:56
Attachments
- signature.asc [application/pgp-signature] 198 bytes
From: Hagen Paul Pfeifer <hidden>
Date: 2013-11-27 21:28:56
* Stephen Hemminger | 2013-11-21 17:54:19 [-0800]:
Patch from developers of the alternative loss models, downloaded from: http://netgroup.uniroma2.it/twiki/bin/view.cgi/Main/NetemCLG We found some bugs in our first implementation. A first set of bugs is in the function loss_4state: In the case 1 of the switch statement in the if conditions we need to add clg->a4 to clg->a1, according to the model. In the case 3 of the switch statement we need to delete "return true" if the condition leads us in the state 1, because the state 1 is a good state.
I already fixed the former bug[1]. I cc'ed stefano.salsano@uniroma2.it but did not get any acked-by/tested-by. The second bug still exists. Hagen [1] http://www.spinics.net/lists/netdev/msg255165.html