Re: [PATCH] usbnet: fix status interrupt urb handling
From: Dan Williams <hidden>
Date: 2013-11-12 17:37:54
On Tue, 2013-11-12 at 16:34 +0100, Felix Fietkau wrote:
Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf "sierra_net: keep status interrupt URB active", sierra_net triggers status interrupt polling before the net_device is opened (in order to properly receive the sync message response). To be able to receive further interrupts, the interrupt urb needs to be re-submitted, so this patch removes the bogus check for netif_running(). Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Signed-off-by: Felix Fietkau <redacted>
Tested-by: Dan Williams <redacted>
quoted hunk
--- drivers/net/usb/usbnet.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 90a429b..8494bb5 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c@@ -204,9 +204,6 @@ static void intr_complete (struct urb *urb) break; } - if (!netif_running (dev->net)) - return; - status = usb_submit_urb (urb, GFP_ATOMIC); if (status != 0) netif_err(dev, timer, dev->net,
-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html