Re: [PATCH net-next 1/5] lib: crc32: clean up spacing in test cases
From: Joe Perches <joe@perches.com>
Date: 2013-10-30 13:57:05
Also in:
linux-sctp, lkml
On Wed, 2013-10-30 at 11:50 +0100, Daniel Borkmann wrote:
This is nothing more but a whitepace cleanup, as 80 chars is not a hard but soft limit, and otherwise makes the test cases arrary really look ugly. So fix it up.
That does look nicer. Another option might be to take the repetitive 6 leading 0's out of column 2 and the repetitive 5 leading 0's out of column 3.
quoted hunk ↗ jump to hunk
diff --git a/lib/crc32.c b/lib/crc32.c
[]
quoted hunk ↗ jump to hunk
@@ -795,206 +795,106 @@ static struct crc_test { u32 crc32c_le; /* expected crc32c_le result */ } test[] = { - {0x674bf11d, 0x00000038, 0x00000542, 0x0af6d466, 0xd8b6e4c1, - 0xf6e93d6c}, - {0x35c672c6, 0x0000003a, 0x000001aa, 0xc6d3dfba, 0x28aaf3ad, - 0x0fe92aca},
[etc...]
+ {0x674bf11d, 0x00000038, 0x00000542, 0x0af6d466, 0xd8b6e4c1, 0xf6e93d6c},
+ {0x35c672c6, 0x0000003a, 0x000001aa, 0xc6d3dfba, 0x28aaf3ad, 0x0fe92aca},
these could be
+ {0x674bf11d, 0x38, 0x542, 0x0af6d466, 0xd8b6e4c1, 0xf6e93d6c},
+ {0x35c672c6, 0x3a, 0x1aa, 0xc6d3dfba, 0x28aaf3ad, 0x0fe92aca},
etc...