Re: [PATCH 13/16] wl1251: enforce changed hw encryption support on monitor state change
From: Pavel Machek <hidden>
Date: 2013-10-30 11:55:08
Also in:
linux-wireless, lkml
On Sat 2013-10-26 22:34:12, Pali Rohár wrote:
From: David Gnedt <redacted> The firmware doesn't support per packet encryption selection, so disable hw encryption support completly while a monitor interface is present to support
"completely".
injection of packets (which shouldn't get encrypted by hw). To enforce the changed hw encryption support force a disassociation on non-monitor interfaces. For disassociation a workaround using hw connection monitor is employed, which temporary enables hw connection manager flag. Signed-off-by: David Gnedt <redacted>
Missing sign-off.
quoted hunk ↗ jump to hunk
index 174f403..f054741 100644--- a/drivers/net/wireless/ti/wl1251/main.c +++ b/drivers/net/wireless/ti/wl1251/main.c@@ -685,6 +685,16 @@ static int wl1251_op_config(struct ieee80211_hw *hw, u32 changed) wl->power_level = conf->power_level; } + /* + * Tell stack that connection is lost because hw encryption isn't + * supported in monitor mode. + * XXX This requires temporary enabling the hw connection monitor flag + */
"of the" and I guess you can remove the XXX? This way it looks like workaround is not complete. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html