Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()
From: David Miller <davem@davemloft.net>
Date: 2013-10-30 02:42:31
Also in:
lkml
From: David Miller <davem@davemloft.net>
Date: 2013-10-30 02:42:31
Also in:
lkml
From: David Mackey <redacted> Date: Tue, 29 Oct 2013 15:16:38 -0700
Using dev_kfree_skb_any() will resolve the below issue when a netconsole message is transmitted in an irq.
...
Signed-off-by: David Mackey <redacted>
This is absolutely not the correct fix. The netpoll facility must invoke ->poll() in an environment which is compatible, locking and interrupt/soft-interrupt wise, as that in which it is normally called. Therefore, bnx2_tx_int(), which is invoked from the driver's ->poll() method, should not need to use dev_kfree_skb_any(). The real problem is somewhere else.