Re: [PATCH 1/2] octeon_mgmt: remove double validation of mac address
From: David Daney <hidden>
Date: 2013-10-29 21:45:18
Also in:
lkml
On 10/29/2013 02:27 PM, Laurent Navet wrote:
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet <redacted>
Luka already sent this exact patch, and I acked his. No need to do it twice. David Daney
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c index 622aa75..1b326cbc 100644 --- a/drivers/net/ethernet/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c@@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) mac = of_get_mac_address(pdev->dev.of_node); - if (mac && is_valid_ether_addr(mac)) + if (mac) memcpy(netdev->dev_addr, mac, ETH_ALEN); else eth_hw_addr_random(netdev);