Thread (8 messages) 8 messages, 4 authors, 2013-10-28

Re: [PATCH 16/16] wl1251: Add sysfs file address for setting permanent mac address

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2013-10-28 15:33:30
Also in: linux-wireless, lkml

On Mon, 28 Oct 2013 15:56:55 +0100
Johannes Berg [off-list ref] wrote:
On Mon, 2013-10-28 at 09:46 -0500, Dan Williams wrote:
quoted
If the device doesn't actually *have* a permanent MAC address, then it
shouldn't be returning one via ethtool, and should return an error for
ETHTOOL_GPERMADDR.
There's currently no provision for that, but I agree it would be better
to do so.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
The current netdevice API handle the case of a device without a permanent
MAC address, slightly differently.

If device does not have a permanent address,
then:
  1. dev->addr_assign_type should not be NET_ADDR_PERM
  2. when device is registered dev->perm_addr will not be set
     and retain all zeros value
  4. when ethtool gets address it will return all zeros which
     is not a valid address.

This case doesn't seem to be handled threo mac80211 API's
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help