[PATCH 0/8] Fix minor address type errors · Ben Hutchings <hidden> · 2013-10-27
[PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types · Ben Hutchings <hidden> · 2013-10-27
Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types · David Miller <davem@davemloft.net> · 2013-10-28
Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types · Ben Hutchings <hidden> · 2013-10-28
Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types · David Miller <davem@davemloft.net> · 2013-10-28
[PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers · Ben Hutchings <hidden> · 2013-10-27
Re: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers · David Miller <davem@davemloft.net> · 2013-10-28
RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers · Venkat Venkatsubra <hidden> · 2013-10-28

Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types

From: David Miller <davem@davemloft.net>
Date: 2013-10-28 04:59:23
Also in: lkml

From: Ben Hutchings <redacted>
Date: Mon, 28 Oct 2013 04:51:25 +0000

On Mon, 2013-10-28 at 00:26 -0400, David Miller wrote:

quoted

From: Ben Hutchings <redacted>
Date: Sun, 27 Oct 2013 21:51:44 +0000

quoted

-     dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len);
+     dbg(DBG_TX, "In fst_tx_dma %x %x %d\n", (u32)skb, mem, len);

Please use %p for the skb pointer instead of casting it (which btw
will introduce a warning on 64-bit).

skb is the DMA address of the data in the sk_buff.  Yes, this is really
unusual naming.

Hmmm, Ok then I guess. :-/