Thread (10 messages) 10 messages, 4 authors, 2013-10-18

Re: [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues

flat view

From: David Miller <davem@davemloft.net>
Date: 2013-10-17 19:56:04
Also in: lkml, virtualization

From: Jason Wang <redacted>
Date: Tue, 15 Oct 2013 11:18:59 +0800
We used to schedule the refill work unconditionally after changing the
number of queues. This may lead an issue if the device is not
up. Since we only try to cancel the work in ndo_stop(), this may cause
the refill work still work after removing the device. Fix this by only
schedule the work when device is up.

The bug were introduce by commit 9b9cd8024a2882e896c65222aa421d461354e3f2.
(virtio-net: fix the race between channels setting and refill)

Cc: Rusty Russell <redacted>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <redacted>
Applied and queued up for -stable, thanks Jason.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help