Thread (2 messages) 2 messages, 2 authors, 2013-10-30

Re: [PATCH] bgmac: pass received packet to the netif instead of copying it

From: David Miller <davem@davemloft.net>
Date: 2013-10-30 20:58:47

From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 30 Oct 2013 08:00:00 +0100
Copying whole packets with skb_copy_from_linear_data_offset is a pretty
bad idea. CPU was spending time in __copy_user_common and network
performance was lower. With the new solution iperf-measured speed
increased from 116Mb/s to 134Mb/s.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
Changes since [RFC TRY#2]:
1) Fixed arguments alignment
2) Dropped code fixing old slot in case of bgmac_dma_rx_skb_for_slot
failure. Thanks to Nathan patch bgmac_dma_rx_skb_for_slot doesn't
change anything in slot in case it failed somewhere.
Looks good, applied to net-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help