-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
On Behalf Of Ben Hutchings
Sent: Tuesday, October 01, 2013 8:59 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; Laura Mihaela Vasilescu; netdev@vger.kernel.org;
gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 9/9] igb: Add ethtool support to configure number of
channels

[..]

In case this fails, is the interface in a consistent state where is it safe to
reconfigure the interface again or to unbind the driver?

If it fails, and the interface was up, shouldn't it call dev_close() so that it's
obviously down and the user can then try to bring it up again?

Ben.

Good question.  I was delayed in replying as I was giving Laura a chance to reply to this thread.  

We call our close routine igb_close(), if the device is up.  This does not call dev_close() specifically, however it’s a good suggestion for the error case.  I'll update the patch.    

Thanks,

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation