Re: [net-next PATCH] net: codel: Avoid undefined behavior from signed overflow
From: Paul E. McKenney <hidden>
Date: 2013-10-30 20:13:34
From: Paul E. McKenney <hidden>
Date: 2013-10-30 20:13:34
On Wed, Oct 30, 2013 at 07:35:48PM +0000, Ben Hutchings wrote:
On Wed, 2013-10-30 at 18:23 +0100, Jesper Dangaard Brouer wrote:quoted
From: Jesper Dangaard Brouer <redacted> As described in commit 5a581b367 (jiffies: Avoid undefined behavior from signed overflow), according to the C standard 3.4.3p3, overflow of a signed integer results in undefined behavior.[...] According to the real processors that Linux runs on, signed arithmetic uses 2's complement representation and overflow wraps accordingly. And we rely on that behaviour in many places, so we use '-fno-strict-overflow' to tell gcc not to assume we avoid signed overflow. (There is also '-fwrapv' which tells gcc to assume the processor behaves this way, but shouldn't it already know how the target machine works?)
We should still fix them as we come across them. There are a few types of loops where '-fno-strict-overflow' results in more instructions being generated. Thanx, Paul