Re: [PATCH net-next] net: extend net_device allocation to vmalloc()
From: Ben Hutchings <hidden>
Date: 2013-10-30 19:16:43
On Wed, 2013-10-30 at 08:01 -0700, Eric Dumazet wrote: [...]
quoted hunk ↗ jump to hunk
--- a/Documentation/networking/netdevices.txt +++ b/Documentation/networking/netdevices.txt@@ -10,9 +10,10 @@ network devices. struct net_device allocation rules ================================== Network device structures need to persist even after module is unloaded and -must be allocated with kmalloc. If device has registered successfully, -it will be freed on last use by free_netdev. This is required to handle the -pathologic case cleanly (example: rmmod mydriver </sys/class/net/myeth/mtu ) +must be allocated with kmalloc() or vmalloc(). If device has registered
[...] Well, drivers must never try to allocate and initialise struct net_device from scratch. They always call alloc_netdev_mqs() or one of its many wrappers. So 'must be allocated with kmalloc' was already wrong and this sentence should be removed completely. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.