Re: [PATCH 1/2] sh_eth: check platform data pointer
From: Sergei Shtylyov <hidden>
Date: 2013-10-30 18:55:16
Also in:
linux-sh
Hello. On 08/31/2013 04:23 AM, Sergei Shtylyov wrote:
Check the platform data pointer before dereferencing it and error out of the probe() method if it's NULL.
This has additional effect of preventing kernel oops with outdated platform data containing zero PHY address instead (such as on SolutionEngine7710).
Signed-off-by: Sergei Shtylyov <redacted>
--- This patch is against Dave's 'net-next.git' repo.
drivers/net/ethernet/renesas/sh_eth.c | 6 ++++++ 1 file changed, 6 insertions(+)
quoted hunk ↗ jump to hunk
Index: net-next/drivers/net/ethernet/renesas/sh_eth.c ===================================================================--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c@@ -2653,6 +2653,12 @@ static int sh_eth_drv_probe(struct platf pm_runtime_enable(&pdev->dev); pm_runtime_resume(&pdev->dev); + if (!pd) { + dev_err(&pdev->dev, "no platform data\n"); + ret = -EINVAL; + goto out_release; + } + /* get PHY ID */ mdp->phy_id = pd->phy; mdp->phy_interface = pd->phy_interface;
David, could you please merge this patch? It has a value of its own,
regardless of the device tree support in patch 2 (which got bloked).
WBR, Sergei