Re: [PATCH] ipv6: remove the unnecessary statement in find_match()
From: Hannes Frederic Sowa <hidden>
Date: 2013-10-30 09:44:13
From: Hannes Frederic Sowa <hidden>
Date: 2013-10-30 09:44:13
On Wed, Oct 30, 2013 at 03:39:26PM +0800, Duan Jiong wrote:
After reading the function rt6_check_neigh(), we can know that the RT6_NUD_FAIL_SOFT can be returned only when the IS_ENABLE(CONFIG_IPV6_ROUTER_PREF) is false. so in function find_match(), there is no need to execute the statement !IS_ENABLED(CONFIG_IPV6_ROUTER_PREF).
It should be constant folded away. But I agree, we can remove this: Acked-by: Hannes Frederic Sowa <redacted> Thanks, Hannes