Thread (1 message) 1 message, 1 author, 2013-10-25

Re: [PATCH net-next 5/5] 6lowpan: remove unecessary break

From: Alexander Smirnov <hidden>
Date: 2013-10-25 13:11:48


 diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
quoted
quoted
index e15b101..09350f1 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -440,7 +440,6 @@ lowpan_uncompress_udp_header(**struct sk_buff *skb,
struct udphdr *uh)
        default:
            pr_debug("ERROR: unknown UDP format\n");
            goto err;
-            break;
        }
 It's not an unnecessary, it's let say a "good coding practice" to have a
quoted
break for every case including default.
   Even after *goto*? :-)

WBR, Sergei
that's my fault, I missed goto here. I already declined my proposal, it's
silly.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help