Re: [PATCH 1/2] net: Add layer 2 hardware acceleration operations for macvlan devices

On Sun, Oct 13, 2013 at 01:46:01PM -0700, John Fastabend wrote:

On 10/11/2013 11:43 AM, Neil Horman wrote:

quoted

Add a operations structure that allows a network interface to export the fact
that it supports package forwarding in hardware between physical interfaces and
other mac layer devices assigned to it (such as macvlans).  this operaions
structure can be used by virtual mac devices to bypass software switching so
that forwarding can be done in hardware more efficiently.

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: john.fastabend@gmail.com
CC: Andy Gospodarek <andy@greyhouse.net>
CC: "David S. Miller" <davem@davemloft.net>
---

[...]

quoted

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 2ddb48d..1710fdb 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h

@@ -426,9 +426,9 @@ struct sk_buff {
 	char			cb[48] __aligned(8);

 	unsigned long		_skb_refdst;
-#ifdef CONFIG_XFRM
+

Is this a hold-over from the previous patches? 'sp' isn't touched
anywhere else so put the ifdef/endif back.

Yeah, my screw up, I wanted to get this out before the weekend and missed that
screw up.  Sorry.

Neil

quoted

 	struct	sec_path	*sp;
-#endif
+
 	unsigned int		len,
 				data_len;
 	__u16			mac_len,

diff --git a/net/core/dev.c b/net/core/dev.c
index 5c713f2..ecad8c2 100644

-- 
John Fastabend         Intel Corporation