Re: [PATCH] can: add Renesas R-Car CAN driver
From: Joe Perches <joe@perches.com>
Date: 2013-09-28 00:40:36
Also in:
linux-can, linux-sh
On Sat, 2013-09-28 at 02:11 +0400, Sergei Shtylyov wrote:
Add support for the CAN controller found in Renesas R-Car SoCs.
trivia:
quoted hunk ↗ jump to hunk
+++ linux-can-next/drivers/net/can/rcar_can.c
[]
+static void rcar_can_rx_pkt(struct rcar_can_priv *priv, int mbx)
+{
+ struct net_device_stats *stats = &priv->ndev->stats;
+ struct can_frame *cf;
+ struct sk_buff *skb;
+ u32 data;
+ u8 dlc;
+
+ skb = alloc_can_skb(priv->ndev, &cf);
+ if (!skb) {
+ stats->rx_dropped++;
+ if (printk_ratelimit())
+ netdev_err(priv->ndev,
+ "%s: alloc_can_skb() failed\n", __func__);This logging message is unnecessary because it's redundant to the generic OOM error in __alloc_skb. It already gets a dump_stack();