Re: [PATCH] ipvs: improved SH fallback strategy
From: Julian Anastasov <ja@ssi.bg>
Date: 2013-09-26 20:00:33
Also in:
lkml, lvs-devel
Hello, On Thu, 26 Sep 2013, Alexander Frolkin wrote:
Improve the SH fallback realserver selection strategy. With sh and sh-fallback, if a realserver is down, this attempts to distribute the traffic that would have gone to that server evenly among the remaining servers. Signed-off-by: Alexander Frolkin <redacted>
Looks correct to me, just fix the below indentations. Also, please use version number for your patches, eg. [PATCHv2] ipvs: ...
quoted hunk ↗ jump to hunk
diff --git a/net/netfilter/ipvs/ip_vs_sh.c b/net/netfilter/ipvs/ip_vs_sh.c index 3588fae..533ea53 100644 --- a/net/netfilter/ipvs/ip_vs_sh.c +++ b/net/netfilter/ipvs/ip_vs_sh.c
+ IP_VS_DBG_BUF(6, "SH: selected unavailable server " + "%s:%d, reselecting", + IP_VS_DBG_ADDR(svc->af, &dest->addr), + ntohs(dest->port));
Indentation: IP_VS_DBG_BUF(6, "SH: selected unavailable server %s:%d, reselecting", IP_VS_DBG_ADDR(svc->af, &dest->addr), ntohs(dest->port));
+ IP_VS_DBG_BUF(6, "SH: selected unavailable " + "server %s:%d (offset %d), reselecting", + IP_VS_DBG_ADDR(svc->af, &dest->addr), + ntohs(dest->port), + roffset);
Indentation: IP_VS_DBG_BUF(6, "SH: selected unavailable " "server %s:%d (offset %d), reselecting", IP_VS_DBG_ADDR(svc->af, &dest->addr), ntohs(dest->port), roffset); Regards -- Julian Anastasov [off-list ref]