Re: [PATCH 1/2] remove all uses of printf's %n

On Thu, Sep 19, 2013 at 9:23 PM, Joe Perches [off-list ref] wrote:

On Fri, 2013-09-20 at 13:09 +0900, Tetsuo Handa wrote:

quoted

Hello.

Tetsuo-san:

quoted

We are discussing about removal of %n support from vsnprintf() at
https://lkml.org/lkml/2013/9/16/52 , and you are using %n in seq_printf().

Well, I'm not using (mere alcohol isn't using, right?)
but I still have the same question for Al.

Are there any races here?

All the call sites I examined were linear. FWIW, I didn't see any races.

-Kees

quoted

I posted https://lkml.org/lkml/diff/2013/9/19/53/1 which introduces
seq_setwidth() / seq_pad() which can avoid use of %n in seq_printf().

I still think adding last_len, last_rtn
is sensible.

-- 
Kees Cook
Chrome OS Security