Thread (2 messages) 2 messages, 2 authors, 2013-09-28

Re: [PATCH] bgmac: add support for Byte Queue Limits

From: Eric Dumazet <hidden>
Date: 2013-09-28 22:18:50

On Sat, 2013-09-28 at 23:23 +0200, Hauke Mehrtens wrote:
This makes it possible to use some more advanced queuing
techniques with this driver.
quoted hunk ↗ jump to hunk
@@ -1198,6 +1206,8 @@ static netdev_tx_t bgmac_start_xmit(struct sk_buff *skb,
 	struct bgmac *bgmac = netdev_priv(net_dev);
 	struct bgmac_dma_ring *ring;
 
+	netdev_sent_queue(net_dev, skb->len);
+
 	/* No QOS support yet */
 	ring = &bgmac->tx_ring[0];
 	return bgmac_dma_tx_add(bgmac, ring, skb);

Well, no.

You must call netdev_sent_queue() only if packet is really queued.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help