Thread (10 messages) flat view 10 messages, 4 authors, 2013-09-24

Re: [net 5/6] i40e: better return values

From: Jesse Brandeburg <hidden>
Date: 2013-09-24 19:09:07

On Tue, 24 Sep 2013 10:12:31 -0400
David Miller [off-list ref] wrote:
quoted
Ick.  post_increment problem.

	return ++num_tc;

There's nothing wrong with the original code
unless this is a bugfix which should be documented
better than "better return values".
Agreed, this style of coding is asking for a bug.

If you want to return "num_tc PLUS ONE" just say that:

	return num_tc + 1;
Oops! Obviously the original post-inc was not the intent. That was my
bad. good catch Joe! will fix and resubmit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help