Re: [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature
From: Anirban Chakraborty <hidden>
Date: 2013-09-22 23:09:41
On Sep 22, 2013, at 7:55 AM, Eric Dumazet [off-list ref] wrote:
On Sat, 2013-09-21 at 17:05 +0100, Wei Liu wrote:quoted
Anirban was seeing netfront received MTU size packets, which downgraded throughput. The following patch makes netfront use GRO API which improves throughput for that case.quoted
- netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO; + netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO | + NETIF_F_GRO;This part is not needed.
Shouldn't the flag be set? In dev_gro_receive() we do check if this flag is set or not:
if (!(skb->dev->features & NETIF_F_GRO) || netpoll_rx_on(skb))
goto normal;
-Anirban