Re: [PATCH 6/7] rtlwifi: Fix smatch warnings in usb.c

On 09/14/2013 02:44 PM, Sergei Shtylyov wrote:

Hello.

On 09/13/2013 09:45 PM, Larry Finger wrote:

quoted

Smatch displays the following:
   CHECK   drivers/net/wireless/rtlwifi/usb.c
drivers/net/wireless/rtlwifi/usb.c:458 _rtl_usb_rx_process_agg() warn:
assigning (-98) to unsigned variable 'stats.noise'
drivers/net/wireless/rtlwifi/usb.c:503 _rtl_usb_rx_process_noagg() warn:
assigning (-98) to unsigned variable 'stats.noise'
drivers/net/wireless/rtlwifi/usb.c:596 _rtl_rx_get_padding() info: ignoring
unreachable code.
drivers/net/wireless/rtlwifi/usb.c:596 _rtl_rx_get_padding() info: ignoring
unreachable code.

quoted

The negative number to an unsigned quantity is fixed by adding 256 to -98
to get the equivalent negative number.

quoted

Signed-off-by: Larry Finger <redacted>
---
  drivers/net/wireless/rtlwifi/usb.c | 10 +++++++---
  1 file changed, 7 insertions(+), 3 deletions(-)

quoted

diff --git a/drivers/net/wireless/rtlwifi/usb.c

b/drivers/net/wireless/rtlwifi/usb.c
index e56778c..9f3dcb8 100644

--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c

[...]

quoted

@@ -582,12 +582,15 @@ static void _rtl_rx_work(unsigned long param)
  static unsigned int _rtl_rx_get_padding(struct ieee80211_hdr *hdr,
                      unsigned int len)
  {
+#if NET_IP_ALIGN != 0
      unsigned int padding = 0;
+#endif

      /* make function no-op when possible */
-    if (NET_IP_ALIGN == 0 || len < sizeof(*hdr))
+    if (NET_IP_ALIGN == 0 || len < sizeof(struct ieee80211_hdr))

    Why this collateral and undocumented change? What does it achieve?

quoted

          return 0;

It does not change a thing. Further up the code is "struct ieee80211_hdr *hdr". 
This change was one I tried during the fixes, and I forgot to remove it.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html