RE: [PATCH v2 1/1] net: fec: fix phy reset operation to let imx6sl evk work

From: David Miller [mailto:davem@davemloft.net]
Data: Friday, September 13, 2013 5:13 AM

To: Duan Fugang-B38611
Cc: shawn.guo@linaro.org; netdev@vger.kernel.org;
bhutchings@solarflare.com; stephen@networkplumber.org; Li Frank-B20596;
s.hauer@pengutronix.de
Subject: Re: [PATCH v2 1/1] net: fec: fix phy reset operation to let
imx6sl evk work

From: Fugang Duan <redacted>
Date: Wed, 11 Sep 2013 10:18:57 +0800

quoted

Current driver only do phy reset in probe function, which is not
right. Since some phy clock is disabled after module probe, the phy
enter abnormal status, which needs do reset to recovery the phy. And
do ifconfig ethx up/down test, the phy also enter abnormal status.

What would disable the PHY clock after the probe?

You have to explain these kinds of things in your changelog message.

Thanks.

David,  there have another patch to saving ethernet power, which will disable phy
And MAC clock after module probe. The patch also include the information to explain
Some cases.

Of course, current Linux-next ethernet cannot work for imx6sl evk platform just because the 
Reset operation is not correct, have no dependency on saving power patch. 

Thanks,
Andy