Re: [PATCH net 1/4] bridge: Don't use VID 0 and 4095 in vlan filtering
From: Vlad Yasevich <hidden>
Date: 2013-09-12 20:57:37
On 09/12/2013 03:55 PM, David Miller wrote:
From: Vlad Yasevich <redacted> Date: Tue, 10 Sep 2013 10:22:26 -0400quoted
On 09/10/2013 06:32 AM, Toshiaki Makita wrote:quoted
IEEE 802.1Q says that: - VID 0 shall not be configured as a PVID, or configured in any - Filtering Database entry. - VID 4095 shall not be configured as a PVID, or transmitted in a tag header. This VID value may be used to indicate a wildcard match for the VID in management operations or Filtering Database entries. (See IEEE 802.1Q-2005 6.7.1 and Table 9-2) Don't accept adding these VIDs in the vlan_filtering implementation. Signed-off-by: Toshiaki Makita <redacted>Reviewed-by: Vlad Yasevich <redacted>Vlad, as far as I can see your redhat.com email ends just with a "c" not a "ch". It's your gmail account that ends in a "ch". I'm fixing this up while applying these patches, if you have something automatically generating these reviewed-by strings please fix it up although I note that some are correct and some are not so maybe you do this by hand :-)
Apologies. Yes, I usually ack things by hand and sometimes fingers just keep going... -vlad