Re: [PATCH] virtio-net: Set RXCSUM feature if GUEST_CSUM is available
From: Rusty Russell <hidden>
Date: 2013-09-02 01:47:57
Also in:
virtualization
From: Rusty Russell <hidden>
Date: 2013-09-02 01:47:57
Also in:
virtualization
David Miller [off-list ref] writes:
From: Thomas Huth <redacted> Date: Tue, 27 Aug 2013 17:09:02 +0200quoted
If the VIRTIO_NET_F_GUEST_CSUM virtio feature is available, the guest does not have to calculate the checksums on all received packets. This is pretty much the same feature as RX checksum offloading on real network cards, so the virtio-net driver should report this by setting the NETIF_F_RXCSUM flag. When the user now runs "ethtool -k", he or she can see whether the virtio-net interface has to calculate RX checksums or not. Signed-off-by: Thomas Huth <redacted>Can one of the virtio_net folks please review this?
Hmm, so NETIF_F_RXCSUM only exists for ethtool's benefit. Weird. But this patch is correct: Acked-by: Rusty Russell <redacted> Thanks, Rusty.