Re: [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS
From: Eric W. Biederman <hidden>
Date: 2013-08-27 01:02:19
Also in:
lkml, stable
Andy Lutomirski [off-list ref] writes:
This is a security bug. The follow-up will fix nsproxy to discourage this type of issue from happening again.
Reviewed-by: "Eric W. Biederman" <redacted>
quoted hunk
Cc: stable@vger.kernel.org Signed-off-by: Andy Lutomirski <luto@amacapital.net> --- net/core/scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/core/scm.c b/net/core/scm.c index 03795d0..b4da80b 100644 --- a/net/core/scm.c +++ b/net/core/scm.c@@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds) return -EINVAL; if ((creds->pid == task_tgid_vnr(current) || - ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) && + ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) && ((uid_eq(uid, cred->uid) || uid_eq(uid, cred->euid) || uid_eq(uid, cred->suid)) || nsown_capable(CAP_SETUID)) && ((gid_eq(gid, cred->gid) || gid_eq(gid, cred->egid) ||