On 8/17/2013 12:16 AM, Sergei Shtylyov wrote:

Hello.

On 08/16/2013 06:11 PM, Lad, Prabhakar wrote:

quoted

From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>

quoted

Add ethernet device tree node information and pinmux for mii to da850 by
providing interrupt details and local mac address.

quoted

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
  arch/arm/boot/dts/da850-evm.dts |    5 +++++
  arch/arm/boot/dts/da850.dtsi    |   30 ++++++++++++++++++++++++++++++
  2 files changed, 35 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/da850-evm.dts

b/arch/arm/boot/dts/da850-evm.dts
index 1f8cfdd..44f3fbc 100644

--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts

@@ -96,6 +96,11 @@
              pinctrl-0 = <&mdio_pins>;
              bus_freq = <2200000>;
          };
+        ethernet: emac@1e20000 {

   Why label the node in the board file too?

May be not required, but all other entries in da850-evm.dts have labels
too. Other .dts files like am335x-bone.dts use labels too (even though
they are never used in references). So I am inclined to let this be like
this and if needed have all the labels removed through a separate patch
- at least we remain consistent within the file that way.

Prabhakar,

Please mind the new e-mail address of the devicetree list.

Thanks,
Sekhar