Re: [net-next 06/10] ixgbe: cleanup some log messages
flat view
From: Joe Perches <joe@perches.com>
Date: 2013-08-28 14:49:46
On Wed, 2013-08-28 at 03:33 -0700, Jeff Kirsher wrote:
From: Don Skidmore <redacted>
Some minor log messages cleanup, changing the level one message is logged, adding a bit of detail to another and put all the text on one line.
Not a comment about this patch but:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c
[]
quoted hunk ↗ jump to hunk
@@ -1282,7 +1282,7 @@ s32 ixgbe_identify_qsfp_module_generic(struct ixgbe_hw *hw) status = 0; } else { if (hw->allow_unsupported_sfp == true) {
At some point it might be nice to remove the
remaining bool direct comparisons to true/false
$ git grep -E -n "(==|!=)\s*(true|false)" drivers/net/ethernet/intel
drivers/net/ethernet/intel/e1000e/netdev.c:4871: (hw->mac.autoneg == true) &&
drivers/net/ethernet/intel/e1000e/phy.c:2651: * Assumes semaphore is already acquired. When page_set==true, assumes
drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c:763: if (hw->phy.reset_disable == false) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c:819: if (hw->mac.orig_link_settings_stored == false) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:954: (hw->phy.smart_speed_active == false))
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:1099: if (hw->phy.reset_disable == false && hw->phy.ops.reset != NULL)
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:1167: if (hw->mac.orig_link_settings_stored == false) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:2371: if (hw->phy.qsfp_shared_i2c_bus == true) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:2397: if (hw->phy.qsfp_shared_i2c_bus == true) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:2424: if (hw->phy.qsfp_shared_i2c_bus == true) {
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c:2450: if (hw->phy.qsfp_shared_i2c_bus == true) {
drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c:1273: if (hw->allow_unsupported_sfp == true) {