Re: [PATCH] tipc: set sk_err correctly when connection fails

On Tue, Aug 27, 2013 at 09:20:23AM -0400, Paul Gortmaker wrote:

What was the high level user visible symptom in this case?
Stalled connections or ... ?

Should the connect fail, if the publication/server is unavailable or some other
error. The connect() call returns the error code directly (as a positive value).

[...]
socket(0x1e /* PF_??? */, SOCK_SEQPACKET, 0) = 3
setsockopt(3, 0x10f /* SOL_?? */, 129, [0], 4) = 0
setsockopt(3, 0x10f /* SOL_?? */, 127, [0], 4) = 0
connect(3, {sa_family=0x1e /* AF_??? */, sa_data="\2\1\322\4\0\0\322\4\0\0\0\0\0\0"}, 16) = 111
sendto(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 66000, 0, NULL, 0) = -1 EPIPE (Broken pipe)

In the strace above, error checking was done as:
if (connect(fd,.....) < 0)
    perror("connect");

//E