Re: [PATCH ipsec v2 1/3] ipv6: wire up skb->encapsulation

On Tue, Aug 20, 2013 at 10:35:46AM +1000, Simon Horman wrote:

On Sun, Aug 18, 2013 at 01:46:52PM +0200, Hannes Frederic Sowa wrote:

quoted

When pushing a new header before current one call skb_reset_inner_headers
to record the position of the inner headers in the various ipv6 tunnel
protocols.

We later need this to correctly identify the addresses needed to send
back an error in the xfrm layer.

This change is safe, because skb->protocol is always checked before
dereferencing data from the inner protocol.

It seems that the intention is to only track the inner-most header
due to the presence of if (likely(!skb->encapsulation)). Is this the
intention?

Ack. Do you see problems with this?

Greetings,

  Hannes