Re: [RFC][PATCH 2/2] bgmac: pass received packet to the netif instead of copying it
From: Felix Fietkau <hidden>
Date: 2013-08-15 11:47:34
On 2013-08-15 1:36 PM, Rafał Miłecki wrote:
2013/8/11 Rafał Miłecki [off-list ref]:quoted
It makes more sense to allocate new (empty) skb and pass it to the hardware. That way we avoid copying whole packet into new skb which should result in better performance.I did some testing of this patch using "perf" tool and iperf -s running on the OpenWrt machine (with bgmac supported hardware). So you can see that __copy_user_common usage has really decreased with this patch! Unfortunately it didn't result in better performance... no idea why :(
Running iperf on the router is not useful as an indicator of routing performance. Please focus on tests where you only push traffic through the router, not directly to it. - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel