Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup
From: Sergei Shtylyov <hidden>
Date: 2013-07-11 12:18:22
Also in:
alsa-devel, linux-input, linux-media, linux-wireless
Hello. On 11-07-2013 13:05, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave().
Cc: Juergen Stuber <redacted> Signed-off-by: Ming Lei <redacted> --- drivers/usb/misc/legousbtower.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 8089479..4044989 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c@@ -771,6 +771,7 @@ static void tower_interrupt_in_callback (struct urb *urb) struct lego_usb_tower *dev = urb->context; int status = urb->status; int retval; + unsigned long flags; dbg(4, "%s: enter, status %d", __func__, status);@@ -788,7 +789,7 @@ static void tower_interrupt_in_callback (struct urb *urb) } if (urb->actual_length > 0) { - spin_lock (&dev->read_buffer_lock); + spin_lock_irqsave (&dev->read_buffer_lock, flags); if (dev->read_buffer_length + urb->actual_length < read_buffer_size) { memcpy (dev->read_buffer + dev->read_buffer_length, dev->interrupt_in_buffer,@@ -799,7 +800,7 @@ static void tower_interrupt_in_callback (struct urb *urb) } else { printk(KERN_WARNING "%s: read_buffer overflow, %d bytes dropped", __func__, urb->actual_length); } - spin_unlock (&dev->read_buffer_lock); + spin_unlock_irqrestore (&dev->read_buffer_lock, flags); }
I don't think this patch passes checkpatch.pl.
WBR, Sergei