Thread (8 messages) 8 messages, 3 authors, 2013-08-01

Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN

From: Joe Perches <joe@perches.com>
Date: 2013-07-29 19:34:27
Also in: linux-acpi, linux-media, linuxppc-dev, lkml

On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote:
On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote:
quoted
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).
[]
quoted
diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
[]
quoted
@@ -44,6 +44,8 @@
[]
quoted
+#include <linux/if_ether.h>
+
[]
quoted
@@ -605,7 +607,7 @@ struct acpi_ibft_nic {
[]
quoted
-	u8 mac_address[6];
+	u8 mac_address[ETH_ALEN];
Please don't touch this file.

It comes from a code base outside of the kernel and should be kept in sync with
the upstream.
Which files in include/acpi have this characteristic?
Perhaps an include/acpi/README is appropriate.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help