Re: [PATCH] virtio-net: put virtio net header inline with data
From: Rusty Russell <hidden>
Date: 2013-07-15 04:23:39
Also in:
lkml, virtualization
"Michael S. Tsirkin" [off-list ref] writes:
On Tue, Jul 09, 2013 at 05:38:51PM +0930, Rusty Russell wrote:quoted
"Michael S. Tsirkin" [off-list ref] writes:quoted
On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote:quoted
"Michael S. Tsirkin" [off-list ref] writes:quoted
For small packets we can simplify xmit processing by linearizing buffers with the header: most packets seem to have enough head room we can use for this purpose. Since existing hypervisors require that header is the first s/g element, we need a feature bit for this. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Note: this needs to be applied on top of patch defining VIRTIO_F_ANY_LAYOUT - bit to be selected by Rusty. The following patch should work for any definition of VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing. Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT and squeeze this patch into 3.11?Sorry, it's too late. First, I've been a bit lax in sending patches via DaveM, and this is definitely his territory (ie. more net than virtio).Let's do this: I'll send a patch series, you ack and we see what happens?If you convince DaveM, I won't object :)quoted
quoted
Secondly, it needs baking and testing time. Cheers, Rusty.I did some testing on this. But proper testing just isn't happening out of tree.But it will get into linux-next for the *next* merge window. Cheers, Rusty.Okay. Can you put it on virtio-next then? I don't see it there ...
Here's the general order: - 1 week before Linus merge window: I stop putting new stuff into xxx-next. - Linus merge window open: I push stuff to Linus, new stuff stays in -pending. - Linus merge window close: I ff my -next trees to -rc1, merge stuff from -pending. In this case, your patch will go from pending-rebases to DaveM, not virtio-next. Which I will do now... Cheers, Rusty.